Skip to content

Upgrade highlight.js to 11.10 #2647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

szabgab
Copy link
Contributor

@szabgab szabgab commented Apr 6, 2025

* highlightBlock was deprecated in favor of highlightElement
* Generate highlight.js based on the languages that are used in the book.

* See rust-lang#2639
@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Apr 6, 2025
@ehuss
Copy link
Contributor

ehuss commented Apr 7, 2025

Does this deal with #1622? That is what has been holding us back from updating.

In general I would prefer to not put any more energy into highlight.js and try to get #1652 moving forward.

@szabgab
Copy link
Contributor Author

szabgab commented Apr 7, 2025

I just checked and this version of highlight.js does not hide the "boring" lines.

It's a pity that from all the highlighting-related issues I did not see that upgrading highlight.js is not possible because of changes in that engine and that you would prefer to move to syntect anyway. I just put in this a lot of time.

I am going to close this PR and the related issue as there is no point in wasting more time on this.

@szabgab szabgab closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants